rust-lang / rust-lang/rustfmt

Double Space between `pub` and type in newtype when an attribute is followed by a comment

Open
#5,997 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-attributes A-comments C-bug I-extraneous-whitespace
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

This looks related to #4671 but the attribute is not very long at all.

This formats with two spaces:

pub struct Newtype(
    /// Doc
    #[doc()] //
    pub  Vec<u8>,
);

This formats with one:

pub struct Newtype(
    /// Doc
    #[doc()]
    pub Vec<u8>,
);

Playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=6abf771bd72b8a98d38368badd4916de

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the formatting difference from the Rust examples or the linked Playground, focusing on the attribute followed by a comment in the tuple field. Trace the formatter path for this input and add coverage for the case; done means the formatted output contains one space between pub and Vec<u8>.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.