rust-lang / rust-lang/rustfmt

rustfmt removes comment between `impl` keyword and type name in impl block

Open
#5,934 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-comments
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

What version are you using?

Rust / Cargo 1.72.0

What did you do?
  1. Wrote this code:

    impl /* CustomAccountInterface for */ Contract {}
    
  2. Formatted it with cargo fmt.

What did you expect to see?
impl /* CustomAccountInterface for */ Contract {}
What did you see instead?

Rustfmt removed my code comment.

impl Contract {}
Discussion

Formatting shouldn't be destructive, but removing comments is destructive.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal Rust snippet in the issue and run it through cargo fmt to reproduce the comment removal. Trace rustfmt's handling of comments between impl and the type name, then add coverage showing that the comment remains after formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.