Comments removed/eaten after generic trait header before body
Open
Nobody has claimed this yet.
A-comments
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Similarly to #4649 and #4774, comments are stripped after trait headers if after a generic parameter:
Before:
trait Foo<T> // my comment
{}
After:
trait Foo<T> {}
Before:
trait Bar<T> /* My comment */ {
fn bar();
}
After:
trait Bar<T> {
fn bar();
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by reproducing the examples for generic trait headers with line and block comments, then compare the behavior with issues #4649 and #4774. Done means rustfmt preserves comments between the generic parameter and the trait body.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100