rust-lang / rust-lang/rustfmt

Version two + hard_tabs adds indent on long generic types

Open
#5,917 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

only-with-option S-duplicate
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

With version=Two

fn foo(
	bar: Box<
		dyn Trait<
			'static,
			aaaaaaaaaaaaaaaaaaa::table,
			bbbbbbbbbbbbbbbbbbb::table,
			diesel::pg::Pg,
			SqlType = sql_types::Nullable<sql_types::Integer>,
		>,
	>,
) {
}

gets reformatted as:

fn foo(
	bar: Box<
		dyn Trait<
				'static,
				aaaaaaaaaaaaaaaaaaa::table,
				bbbbbbbbbbbbbbbbbbb::table,
				diesel::pg::Pg,
				SqlType = sql_types::Nullable<sql_types::Integer>,
			>,
	>,
) {
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the formatting with rustfmt using version=Two, hard_tabs, and the provided long generic type example. Trace the indentation handling for nested generic types and add regression coverage; done means the inner lines are not given the extra tab shown in the report.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.