rust-lang / rust-lang/rustfmt

rustfmt breaks macros involving $

Open
#5,905 2 comments 0 reactions 1 assignee View on GitHub

@rscprof is already working on this.

Since Jan 17, 2024.

A-macros C-bug
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

This macro:

macro_rules! test_macro {
    ($member:ident $($rest:tt)*) => {
        paste::paste! {fn test(&self) {
        (self.$member$($rest)* )
        }}
    };
}

gets wrongly reformatted as:

macro_rules! test_macro {
    ($member:ident $($rest:tt)*) => {
        paste::paste! {fn test(&self) {
        (self.$$member($rest)* )
        }}
    };
}

The diff being:

4c4
<         (self.$member$($rest)* )
---
>         (self.$$member($rest)* )

The version being:
rustfmt 1.6.0-stable (5680fa1 2023-08-23)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.