rust-lang / rust-lang/rustfmt

Can't have single line let-else and control braces on next line

Open
#5,849 4 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

only-with-option
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

let-else always expands to multiple lines if control_brace_style = "AlwaysNextLine". I don't know if this is a bug or simply not supported.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the let-else formatting behavior with control_brace_style set to "AlwaysNextLine". Inspect rustfmt's formatting path for let-else and its existing regression tests, then determine whether the single-line form is supported. Done means the behavior is corrected or explicitly documented, with a regression test covering the result.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.