"left behind trailing whitespace" when breaking after visibility of a field
Open
Nobody has claimed this yet.
A-visibility
C-bug
I-trailing-whitespace
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
$ rustup run nightly cargo fmt -- --check
Diff in /home/jplatte/code/matrix-rust-sdk/crates/matrix-sdk/src/room/timeline/event_item/content.rs at line 292:
/// of the sender of the reaction.
#[derive(Clone, Debug, Default)]
pub struct ReactionGroup(
- pub(in crate::room::timeline)
+ pub(in crate::room::timeline)
IndexMap<(Option<OwnedTransactionId>, Option<OwnedEventId>), OwnedUserId>,
);
error[internal]: left behind trailing whitespace
--> /home/jplatte/code/matrix-rust-sdk/crates/matrix-sdk/src/room/timeline/event_item/content.rs:295:295:34
|
295 | pub(in crate::room::timeline)
| ^
|
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reported reproduction command, rustup run nightly cargo fmt -- --check, and inspect crates/matrix-sdk/src/room/timeline/event_item/content.rs around line 292. Trace how rustfmt handles a field visibility modifier followed by a line break, then add coverage for the shown case and confirm the check no longer reports trailing whitespace.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100