False negative with `error_on_line_overflow` in Clippy source file
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
The issue concerns this line:
https://github.com/rust-lang/rust-clippy/blob/98c4a49db8c305c468646715b773fa9b6ec7049a/clippy_lints/src/derive.rs#L350
The line is 130 characters long, which exceeds the max_width declared in the rustfmt.toml file:
https://github.com/rust-lang/rust-clippy/blob/98c4a49db8c305c468646715b773fa9b6ec7049a/rustfmt.toml#L1
Yet none of these commands produce a change or error:
cargo fmt
rustfmt clippy_lints/src/derive.rs
cargo +nightly fmt
rustfmt +nightly clippy_lints/src/derive.rs
(Re +nightly, recall Clippy uses a rust-toolchain file.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the listed cargo fmt and rustfmt commands against clippy_lints/src/derive.rs, using the max_width setting in rustfmt.toml and the toolchain specified by rust-toolchain. Compare the result for the referenced line with the reported 130-character length; done means the overflow is either formatted or reported consistently with error_on_line_overflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100