rust-lang / rust-lang/rustfmt

Indentation failure with many generic arguments

Open
#5,657 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-call-chains S-duplicate
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

When a set of generic arguments hits max-width, rustfmt seems to have trouble with indentation.

Here's an example:

fn omg() {
fn bar() {
self.core
.exchange::<LeaseBufReader<_, BUFSIZ>, _, LeaseBufWriter<_, BUFSIZ>, _>(
device_index,
src,
dest,
)
.map_err(RequestError::from)
}
}
$ rustfmt --config max_width=80 test.rs
fn omg() {
    fn bar() {
        self.core
.exchange::<LeaseBufReader<_, BUFSIZ>, _, LeaseBufWriter<_, BUFSIZ>, _>(
device_index,
src,
dest,
)
.map_err(RequestError::from)
    }
}

It properly indents the functions, but then gives up on the call to .exchange<...>.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the Rust snippet in test.rs using rustfmt --config max_width=80 test.rs. Trace the formatting path for the multiline generic .exchange call, then verify that its receiver and arguments retain the surrounding function indentation without regressing the shown formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.