rust-lang / rust-lang/rustfmt

[Feature request] Vertical formatting for attributes

Open
#5,646 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

B-prerequisite-rustfmt-changes C-feature-request S-blocked
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Hi, it would be really cool if an attribute's content could be arranged in more ways. (Similar to array_width)

Example:

Currently, if you have this attribute:

#[diagnostic(
    code(...),
    url(...),
    severity(...)
)]
fn x() {...}

It will get rearranged to:

#[diagnostic(code(...), url(...), severity(...))]
fn x() {...}

It would be useful if there was an option specifically for vertical formatting in attributes' content

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no source file, test, or entry point. Start by locating existing array_width handling in rustfmt's attribute-formatting code, then define the vertical-layout option and add coverage for the diagnostic example; done means the option reliably produces the requested vertical arrangement.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.