rust-lang / rust-lang/rustfmt

Remove extra unnecessary blocks

Open
#5,616 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature-request community driven P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Description

It should be safe to remove unnecessarily nested blocks when there's no statements in between: {{{ <stmts> }}} => { <stmts> }.

Example

Input:

fn f() {
    {{{{{ g() }}}}};
}

Expected output:

fn f() {
  g();
}

Actual output:

fn f() {
    {
        {
            {
                {
                    {
                        g()
                    }
                }
            }
        }
    };
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the Rust input from the issue with rustfmt, then trace the formatter entry point that handles nested blocks and compare its output with the expected flattened block; done means unnecessary empty nesting is removed without changing statements.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.