rust-lang / rust-lang/rustfmt

comment in let statement prevents formatting

Open
#5,590 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-comments P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

When running the rustfmt on a line that contains a block comment, the lines doesn't get formatted at all. My expectation is that the line gets formatted correctly as if the comment block wasn't there.
rustfmt version: rustfmt 1.5.1-stable
Test case:

fn main() {
    let tup = (1, 2);
    let (first,         second)/* your pattern here */ = tup;
}

Expectation:

fn main() {
    let tup = (1, 2);
    let (first, second)/* your pattern here */ = tup;
}

Actual:

fn main() {
    let tup = (1, 2);
    let (first,         second)/* your pattern here */ = tup;
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with rustfmt 1.5.1-stable using the let statement and block comment shown in the issue. Trace how rustfmt handles comments in let-pattern formatting, then add coverage for this example and confirm the spacing is normalized while preserving the comment.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.