comment in let statement prevents formatting
Open
Nobody has claimed this yet.
A-comments
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
When running the rustfmt on a line that contains a block comment, the lines doesn't get formatted at all. My expectation is that the line gets formatted correctly as if the comment block wasn't there.
rustfmt version: rustfmt 1.5.1-stable
Test case:
fn main() {
let tup = (1, 2);
let (first, second)/* your pattern here */ = tup;
}
Expectation:
fn main() {
let tup = (1, 2);
let (first, second)/* your pattern here */ = tup;
}
Actual:
fn main() {
let tup = (1, 2);
let (first, second)/* your pattern here */ = tup;
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with rustfmt 1.5.1-stable using the let statement and block comment shown in the issue. Trace how rustfmt handles comments in let-pattern formatting, then add coverage for this example and confirm the spacing is normalized while preserving the comment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100