"left behind trailing whitespace" in long patterns
Open
Nobody has claimed this yet.
A-matches
I-poor-formatting
I-trailing-whitespace
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Code like this:
fn put_telescope_synctocoordinates(
PutTelescopeSynctocoordinatesPathParams {
device_number,
}: PutTelescopeSynctocoordinatesPathParams,
) {
}
triggers "left behind trailing whitespace".
I suppose it's because rustfmt tries to put entire param - both pattern and type - on the same line, fails in doing so as that exceeds the max width, and gives up. Instead, it should probably fallback to something like
fn put_telescope_synctocoordinates(
PutTelescopeSynctocoordinatesPathParams {
device_number,
}: PutTelescopeSynctocoordinatesPathParams,
) {
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported formatting with the long Rust function parameter pattern and the repository's maximum-width settings. Trace the formatter path for long destructuring patterns, add a regression test for the example, and verify that formatting produces the intended indentation without trailing whitespace.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100