rust-lang / rust-lang/rustfmt

Support matches! with if guard

Open
#5,547 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-macros C-feature-request P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

rustfmt struggles with matches! and if guards.

fn test() {
    let a = matches!(something.very_very_very.long.even.more.fields, Some(very_long_field_name_name_to_check) if method(very_long_field_name));
}

rustfmt 1.5.1-nightly (c0941dfb 2022-08-21)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported rustfmt behavior with the provided matches! example and the noted nightly version. Trace the formatter's handling of matches! expressions and if guards; done means the example formats successfully without the reported struggle.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.