rust-lang / rust-lang/rustfmt

rustfmt removes double colons in macro

Open
#5,526 4 comments 0 reactions 1 assignee View on GitHub

@ytmimi is already working on this.

Since Sep 1, 2022.

A-macros C-bug
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Hello,

rustfmt will remove :: from a macro.

To illustrate:

construct_runtime!(
    pub struct Runtime
    where
        Block = Block,
        NodeBlock = generic::Block<Header, sp_runtime::OpaqueExtrinsic>,
        UncheckedExtrinsic = UncheckedExtrinsic,
    {
        Council: pallet_collective::<Instance1>,
        TechnicalCommittee: pallet_collective::<Instance2>,
    }
);

After running cargo fmt:

construct_runtime!(
    pub struct Runtime
    where
        Block = Block,
        NodeBlock = generic::Block<Header, sp_runtime::OpaqueExtrinsic>,
        UncheckedExtrinsic = UncheckedExtrinsic,
    {
        Council: pallet_collective<Instance1>,   <<== '::' is gone
        TechnicalCommittee: pallet_collective<Instance2>,
    }
);

The compilation will fail afterwards.
We're using Rust nightly-2022-07-24.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.