rust-lang / rust-lang/rustfmt

Rustfmt silently removes comments after enum/struct field

Open
#5,464 11 comments 2 reactions 1 assignee View on GitHub

@NishantJoshi00 is already working on this.

Since Oct 13, 2024.

A-comments C-bug P-medium
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Examples:

enum Enum{
    Variant { field /*comment*/ : i32}
}

struct S {
    field /* comment */ : i32
}

Both comments get removed without any warning.

Since this seems to be a recurring issue (#5297, #4708, #2781, https://github.com/rust-lang/rust/issues/52444), would it be possible to find some (temporary) middle ground, such as emitting warnings? Can rustfmt get a list of all comments in the code before and after formatting to compare if any went missing?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.