rust-lang / rust-lang/rustfmt

Feature Request: Add reorder_impl_blocks option

Open
#5,441 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature-request P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Discussion for reorder_impl_blocks configuration option. Implemented by: TBD.

This option enforces ordering of impl blocks such that struct implementations precede trait implementations.

struct MyStruct { ... }
impl fmt::Debug for MyStrict { ... }
impl MyStruct { ... }
impl Drop for MyStruct { ... }

to

struct MyStruct { ... }
impl MyStruct { ... }
impl fmt::Debug for MyStrict { ... }
impl Drop for MyStruct { ... }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names the proposed reorder_impl_blocks configuration option and shows the desired ordering of inherent and trait impl blocks. Start by tracing rustfmt's configuration handling and formatting entry points for impl blocks; the issue names no files or tests. Done means the option enforces the demonstrated ordering without changing behavior when it is disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.