Closure fails to format correctly when there are too many generics
Open
Nobody has claimed this yet.
A-closures
I-poor-formatting
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
I'm using vanilla settings.
let _ = |first, second: SomeType<With, Many, Many, Many, Many, Many, Many, Many, Many, Generic, Arguments>, third| {};
...formats to...
let _ = |first,
second: SomeType<
With,
Many,
Many,
Many,
Many,
Many,
Many,
Many,
Many,
Generic,
Arguments,
>,
third| {};
Is this expected behavior? I would have expected...
let _ = |first,
second: SomeType<
With,
Many,
Many,
Many,
Many,
Many,
Many,
Many,
Many,
Generic,
Arguments,
>,
third| {};
...or (I'm not a big fan of the 1 space indentation for closure arguments)...
let _ = |
first,
second: SomeType<
With,
Many,
Many,
Many,
Many,
Many,
Many,
Many,
Many,
Generic,
Arguments,
>,
third
| {};
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the provided closure example with rustfmt's vanilla settings and compare the actual output with both proposed alternatives. Investigate the formatter paths responsible for closure arguments and generic argument indentation. Done means the formatting behavior is agreed upon and the reproduced case produces the selected consistent output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100