rust-lang / rust-lang/rustfmt

Feature request: Add semicolon after assignment if it is at the end of a block

Open
#5,363 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-blocks A-statements C-feature-request P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

It would be nice if curly-braced blocks that end in a = b, a += b or such could have a semicolon added after that assignment. This would make it more explicit that the operation returns nothing of interest out of the block.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by locating rustfmt's block and assignment formatting logic and its existing tests, then determine how terminal assignments should be represented; done means eligible assignments at the end of curly-braced blocks consistently receive a semicolon without changing other block expressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.