rust-lang / rust-lang/rustfmt

Rustfmt inserts newlines before `where` blocks regardless of length

Open
#5,352 5 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature-request P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

I'm sure I'm not the only one to have been caught by this, but I've not been able to locate either existing or historical options to deal with this, nor any existing issues.

Anyway, the following snippet, despite not exceeding any of the line length limits in any fashion (that I'm aware of) is still chopped up into multiple lines.

Before:

pub struct S<T> where T: Copy {
    pub value: T,
}

After:

pub struct S<T>
where
    T: Copy,
{
    pub value: T,
}

I would really appreciate an option to keep where blocks on the same line as their attached item until they exceed a maximum length - my vertical space is quite precious and it's fairly irritating to have already-concise lines which fall well short of the column limit suddenly take up double the number of lines.

I'm not sure whether this is a bug (because it does seem excessive) or whether rustfmt is just lacking an option to do this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the supplied Rust snippet with rustfmt and comparing the current output with the requested compact where-clause layout. Trace the formatter's handling of where blocks and determine whether the change should be an option or a default behavior; done means concise blocks remain on one line when within the configured limit, with coverage for the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.