rust-lang / rust-lang/rustfmt

Deleted comments in type aliases

Open
#5,297 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-comments P-medium
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Some inline comments in type alias declarations are removed during formatting.

Steps to reproduce:

$ rustfmt --version
rustfmt 1.4.38-stable (9d1b210 2022-02-23)
$ rustfmt --emit stdout <(echo 'type Cycle = [u64 /* seconds */; 3];')

Expected output:

type Cycle = [u64 /* seconds */; 3];

Actual output:

type Cycle = [u64; 3];

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the provided rustfmt --emit stdout reproduction first. Trace the formatting path for the type alias and its inline comment, then verify that formatting preserves the comment and matches the expected output.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.