trailing comma after function call chains may need a comment barrier
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
When given a function call chain, and a comment rustfmt will move the comma above the comment,
which cause
fn main() {
().foo(
().foo
.foo()
.foo()
.foo()
.foo()
.foo()
.foo()
.foo()
.foo()
.foo()
.foo()
//.foo()
,
)
}
afterwords the last line looks like:
.foo(), //.foo()
Which moves the comment from the first parameter, to the second (nonexistent!) parameter if one were to uncomment it,
This makes the addition of a comment, followed by rustfmt, followed by the removal of a comment syntactically invalid which can be inconvenient.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the formatting change with the function-call chain and commented-out .foo() shown in the issue. Trace the formatter entry point that handles trailing commas and comments, then add coverage for this example; done means formatting preserves a comment barrier so uncommenting the call remains syntactically valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100