rust-lang / rust-lang/rustfmt

Semicolon should be removed after `match`, `if` etc. where nothing happens with the return value

Open
#5,127 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-statements C-feature-request P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

match () {
    () => {},
};
if () == () {};

In both examples I would expect rustfmt to remove the semicolon.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running rustfmt on the two examples in the issue and inspect how it formats standalone match and if expressions. Trace the relevant formatting path, then verify that both unnecessary semicolons are removed and add or update regression coverage for these cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.