alphabetical order for type in trait definition also
Open
Nobody has claimed this yet.
C-feature-request
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
I have code snippet below:
pub trait DataValue {
type Value;
type Mutation;
}
impl DataValue for Int64 {
type Mutation = Int64Mutation;
type Value = Int64Value;
}
where rustfmt will force types in the impl block in alphabetical order, but not for the trait block.
IntelliJ complains "Different impl member order from the trait" in this case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the Rust snippet in the issue as the reproduction: run rustfmt on the trait and impl and compare their associated-type ordering. Investigate the formatter paths responsible for each block; done means the trait definition and impl produce consistent alphabetical ordering, with a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100