rust-lang / rust-lang/rustfmt

Reorders imports of modules containing `#![macro_use]`

Open
#4,959 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-modules
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Similar to https://github.com/rust-lang/rustfmt/issues/2399, rustfmt will still reorder mod statements of modules that contain a #![macro_use] attribute, as opposed to the mod itself being annotated with #[macro_use]. This is equivalently invalid reordering.

rustfmt 1.4.36-nightly

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the import-reordering behavior with rustfmt 1.4.36-nightly and compare it with the related rust-lang/rustfmt#2399 issue. The issue names no source files or tests, so locate the module-ordering logic and add a regression test showing that modules containing #![macro_use] are not reordered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.