rust-lang / rust-lang/rustfmt

Inline comments in declarations get deleted

Open
#4,905 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-comments P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Rustfmt converts

pub /*const*/ fn cant_be_const_yet() {}
pub fn cant_be_const_yet() {}

I'd really like to keep that comment. =(


$ rustfmt --version
rustfmt 1.4.37-stable (2a3635d 2021-05-04)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the shown Rust input and the reported rustfmt 1.4.37-stable version, comparing the formatted output with the inline comment preserved. Identify the rustfmt formatting path responsible for declarations, then verify that the comment remains in the formatted result.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.