rust-lang / rust-lang/rustfmt

Problem with comment after the function opening parenthesis

Open
#4,863 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-comments P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

This code

fn f(
    // a: &str
) {
}

is formatted into

fn f(// a: &str
) {
}

i expect it to be kept as is.

Here is the rustfmt version I used:

$ rustfmt --version
rustfmt 1.4.37-nightly (625d5a6 2021-06-01)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the formatting change with the shown Rust snippet using the reported rustfmt 1.4.37-nightly version, then trace how rustfmt handles comments immediately after an opening parenthesis. Done means the comment remains on its own line as in the input, with a regression test covering this example.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.