rust-lang / rust-lang/rustfmt

Rustfmt fails to merge conditional imports with same condition

Open
#4,642 0 comments 2 reactions 1 assignee View on GitHub

@topecongiro is already working on this.

Since Jan 14, 2021.

A-imports C-feature-request P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Input

#[cfg(windows)]
use glium::glutin::platform::windows::EventLoopExtWindows;
#[cfg(windows)]
use glium::glutin::{platform::windows::IconExtWindows, window::Icon};

Output

#[cfg(windows)]
use glium::glutin::platform::windows::EventLoopExtWindows;
#[cfg(windows)]
use glium::glutin::{platform::windows::IconExtWindows, window::Icon};

Expected output

#[cfg(windows)]
use glium::glutin::{platform::windows::{EventLoopExtWindows, IconExtWindows}, window::Icon};

Meta

  • rustfmt version: rustfmt 1.4.27-nightly (580d826e 2020-11-16)
  • From where did you install rustfmt?: rustup

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.