rustfmt is slow on pest generated grammars
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Rustfmt takes about a minute to reformat 26k file (generated pest grammar).
File in question: https://github.com/steveklabnik/semver-parser/blob/0c43dbb12d35f9b58142b3976391eb52ea71725f/src/generated.rs
To Reproduce
Run this test in the semver-parser repo:
Expected behavior
Formatting takes low-digits seconds.
Meta
- rustfmt version: rustfmt 1.4.20-stable (48f6c32 2020-08-09)
- From where did you install rustfmt?: rustup
- How do you run rustfmt: https://github.com/steveklabnik/semver-parser/blob/0c43dbb12d35f9b58142b3976391eb52ea71725f/tests/genpest.rs#L68-L84
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the report by running the test at tests/genpest.rs, especially the command around lines 68-84, against src/generated.rs from the linked semver-parser revision. Start by measuring the current formatting time and tracing the rustfmt path used by that test; done means formatting the 26k generated file completes in the reported low-single-digit seconds or the remaining limitation is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- performance, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 43/100