rust-lang / rust-lang/rustfmt

Newlines before comments that describe function arguments get removed

Open
#4,299 0 comments 3 reactions 1 assignee View on GitHub

@topecongiro is already working on this.

Since Jun 30, 2020.

A-comments I-poor-formatting P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Input

fn main() {
    foo(
        // First argument
        10.0,
        // Second argument
        "bar",
        // Third argument
        None,
    );
}

Output

fn main() {
    foo(
        // First argument
        10.0, // Second argument
        "bar", // Third argument
        None,
    );
}

Expected output

Either don't change anything, or,

fn main() {
    foo(
        10.0, // First argument
        "bar", // Second argument
        None, // Third argument
    );
}

Meta

  • rustfmt version: rustfmt 1.4.16-stable (939e164 2020-06-11)
  • From where did you install rustfmt?: rustup, I think.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.