No trailing comma changes in debug_assert calls
Open
Nobody has claimed this yet.
A-macros
I-poor-formatting
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
rustfmt does not change trailing commas in debug_assert invocations, and both of the following are left unchanged:
debug_assert(a == b,);
debug_assert(a == b);
While obviously macros should be handled with care, rustfmt should be able to handle at least common function-like ones as if they were functions, I think.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing rustfmt's handling of function-like macro invocations, using the two debug_assert examples as regression cases. Done means trailing-comma normalization matches ordinary function-like calls for these examples without changing unrelated macro formatting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100