No formatting in arguments passed to macros defined with `=>`
Open
Nobody has claimed this yet.
A-macros
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
rustfmt (both stable 1.42.0 and nightly of 12-Apr-2020) does not format arguments of macros defined with =>.
For example, test_arrow!(...) usage below is left as is (with extra whitespaces) after rustfmt, while similar test_comma!(...) is formatted correctly (i.e. original extra space is removed):
macro_rules! test_arrow {
($x:expr => $y:expr) => {
println!("{} {}", $x, $y);
};
}
macro_rules! test_comma {
($x:expr, $y:expr) => {
println!("{} {}", $x, $y);
};
}
fn main() {
test_arrow!("hello" => 2 + 2);
test_comma!("hello", 2 + 2);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the supplied test_arrow! and test_comma! macro examples using rustfmt, then trace the macro-formatting entry point that handles their arguments. Done means the test_arrow! invocation formats its extra whitespace consistently with test_comma!.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100