`cargo fmt` does not do anything in tokio repo
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
I found this problem locally and wondered how tokio was checking formatting in CI.
As you can see they are calling rustfmt directly:
https://github.com/tokio-rs/tokio/blob/master/ci/azure-rustfmt.yml#L17
This comment links to a cargo issue:
https://github.com/rust-lang/cargo/issues/7732
However, this cargo issue is closed and it's not clear how it's related.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tokio's ci/azure-rustfmt.yml at the referenced line and compare its direct rustfmt invocation with cargo fmt. Read the linked cargo issue #7732 to determine whether it explains the behavior. Done requires a clear explanation of why cargo fmt does nothing in this repository and what, if anything, should change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100