rust-lang / rust-lang/rustfmt

Add option to put pub imports (aka exports) before normal imports

Open
#4,070 3 comments 19 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-imports C-feature-request
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Context: When reorder_imports = true, rustfmt mixes pub imports in with private imports.
Please add an option to put pub imports (aka exports) before normal imports.
IMO it's not idiomatic to mix them in with normal imports because they are also exports and deserve extra attention so I usually put them before normal imports and then leave an empty line between.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing rustfmt's existing reorder_imports option and the tests or configuration documentation that define its behavior. Determine where public imports are classified and ordered, then specify how a new option should group them before private imports and insert the requested blank line; done means the option is documented and covered by formatter tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.