rust-lang / rust-lang/rustfmt

rustfmt seems to have stopped formatting files behind configurations?

Open
#4,034 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-macros A-modules P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

rustfmt 1.4.11-nightly (18382352 2019-12-03)

Recently all of my files that are behind config flags stopped formatting with cargo fmt, even if the code would be configured into a current build (eg: a cfg(windows) module on a windows machine).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report with cargo fmt using files or modules behind cfg flags, including a cfg(windows) module on a Windows build. Start by tracing how rustfmt discovers configuration-gated code; done means cargo fmt formats code that is enabled in the current build, rather than skipping it.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.