Incorrect whitespace when match_arm_blocks set to false
Open
Nobody has claimed this yet.
C-bug
I-trailing-whitespace
only-with-option
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
When the config option for match_arm_blocks is set to false, the formatter adds additional whitespace which causes errors saying: 'error[internal]: left behind trailing whitespace'
For example:
match pos_iter.peek()
{
Some(pos) if pos.0 != 0 =>
add_paragraphs_to_map(&doc[0..pos.0], 0, current_level, &mut paragraphs),
None => add_paragraphs_to_map(doc, 0, current_level, &mut paragraphs),
_ => (),
}
// becomes
match pos_iter.peek()
{
Some(pos) if pos.0 != 0 =>
add_paragraphs_to_map(&doc[0..pos.0], 0, current_level, &mut paragraphs),
None => add_paragraphs_to_map(doc, 0, current_level, &mut paragraphs),
_ => (),
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the example with match_arm_blocks set to false and inspect the formatter path that handles match arms. Add a regression test covering the shown input and verify that formatting no longer leaves trailing whitespace or inserts the extra blank line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100