format_macro_matchers deletes comments
Open
Nobody has claimed this yet.
A-macros
C-bug
only-with-option
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
When I just have a .rustfmt.toml with:
unstable_features = true
format_macro_matchers = true
Rustfmt 1.4.9 will the delete the comment in this:
macro_rules! m {
(
$arg0:ident, // comment
) => {};
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the report with a .rustfmt.toml enabling unstable_features and format_macro_matchers, then format the shown macro_rules! example. Trace the formatter path handling macro matchers and verify that the inline comment remains present after formatting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100