rust-lang / rust-lang/rustfmt

two runs required on imports with leading ::

Open
#3,943 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-imports C-bug only-with-option
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Formatting can take two runs when imports are using absolute paths and include leading :: (when using the 2018 edition config option)

Original source:

use ::foo;
use ::foo::{Bar};
use ::foo::{Bar, Baz};
use ::{Foo};
use ::{Bar, Baz};

1st formatting result:

use ::foo;
use ::foo::Bar;
use ::foo::{Bar, Baz};
use ::Foo;
use ::{Bar, Baz};

And then second formatting run to get the final result:

use ::Foo;
use ::foo;
use ::foo::Bar;
use ::foo::{Bar, Baz};
use ::{Bar, Baz};

Seems to be related to the first run reducing ::{Foo} to ::Foo but without fully sorting/reordering the set of imports, and then the second run sorting them to finish formatting.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the Rust import examples in the report, using the 2018 edition configuration. Trace the import formatting and sorting entry points involved in reducing leading-:: imports; done means one formatting run produces the final ordering and a second run makes no further changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.