rust-lang / rust-lang/rustfmt

Uses visual style for long closure arguments

Open
#3,865 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

I-poor-formatting
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

rustfmt seems to use visual style rather than block style when reformatting long closure argument lists:

    let write_status = |status: &mut Vec<ansi_term::ANSIString>,
                        diff: &Diff,
                        heading: &str,
                        color: &Style,
                        show_hints: bool,
                        hints: &[&str]|
     -> Result<bool> {

One possible block-style alternative rustfmt could use:

    let write_status = |
        status: &mut Vec<ansi_term::ANSIString>,
        diff: &Diff,
        heading: &str,
        color: &Style,
        show_hints: bool,
        hints: &[&str]
    | -> Result<bool> {

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the rustfmt formatting shown for a closure with a long argument list. Compare the current visual style with the proposed block style; done means rustfmt consistently applies the intended style and covers this formatting case with a regression check.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.