rust-lang / rust-lang/rustfmt

Visual ident style of `if` in closure is wrong

Open
#3,634 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-call-chains A-closures I-poor-formatting only-with-option P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

This

fn test() {
    let aaaaaaaaaaaaaaaa = ffffffffffffffffffffffff
        .iter()
        .filter_map(|_| {
            if bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
                == ccccccccccccccccccccccc
                    .dddddddddddddddddddddddd()
                    .eeeeeeeeeeeeeeeeeeeeee()
            {
                ();
            }
        })
        .collect();
}

is turned into this

fn test() {
    let aaaaaaaaaaaaaaaa = ffffffffffffffffffffffff.iter()
                                                   .filter_map(|_| {
                                                       if bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
                == ccccccccccccccccccccccc
                    .dddddddddddddddddddddddd()
                    .eeeeeeeeeeeeeeeeeeeeee()
            {
                ();
            }
                                                   })
                                                   .collect();
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Rust input and output shown in the issue with rustfmt. Trace formatting for an if expression inside a closure, then verify that the chained calls and the closure body are indented consistently without changing the intended formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.