rust-lang / rust-lang/rustfmt

Non-multiple of four indentation in closure arg pattern

Open
#3,267 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

I-poor-formatting P-medium
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

The following unformatted line:

fn f() {
    let y = x.into_iter().map(|AaaaaaAaaaaaaaaaa{bbbbbb_bbbb,ccc_ccccccc}|());
}

currently gets formatted as:

fn f() {
    let y = x.into_iter().map(
        |AaaaaaAaaaaaaaaaa {
             bbbbbb_bbbb,
             ccc_ccccccc,
         }| (),
    );
}

This has some lines with 13 and 9 space indentation, which contradicts the indentation convention in the style guide RFC.

Each level of indentation must be four spaces (that is, all indentation outside of string literals and comments must be a multiple of four).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported formatting with the Rust snippet in this issue, then trace the rustfmt handling for closure argument patterns. Add a regression test for this input and verify that every generated indentation level is a multiple of four, matching the linked style guide convention.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.