rust-lang / rust-lang/rustfmt

remove stray comma from cfg-attr allow()

Open
#3,228 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

#![cfg_attr(feature = "cargo-clippy", allow(clippy::inline_always,)]
could be formatted to #![cfg_attr(feature = "cargo-clippy", allow(clippy::inline_always)].

Note that this already works for just #![allow(nline_always,)]

rustfmt 1.0.0-nightly (43206f4 2018-11-30)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the provided cfg_attr example using rustfmt 1.0.0-nightly (43206f4 2018-11-30), then compare it with the standalone allow example. Done means formatting removes the stray comma in cfg_attr while preserving valid allow syntax.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.