Comments on `extern crates` that are reordered get misplaced
Open
Nobody has claimed this yet.
A-comments
A-imports
I-unexpected-motion
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
0.99.6-nightly (2018-10-18 750b252)
Before
extern crate serde; // 1.0.78
extern crate serde_json; // 1.0.27
extern crate serde_derive; // 1.0.78
After
extern crate serde; // 1.0.78
extern crate serde_derive;
extern crate serde_json; // 1.0.27 // 1.0.78
Expected
extern crate serde; // 1.0.78
extern crate serde_derive; // 1.0.78
extern crate serde_json; // 1.0.27
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the Rust input shown in the report and trace how rustfmt reorders extern crate declarations while carrying comments. The work is done when the comments remain attached to their original crates and the formatted output matches the expected example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100