Poor formatting of macro_rules rhs with consecutive top-level blocks
Open
Nobody has claimed this yet.
A-macros
I-poor-formatting
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Rustfmt turns this input:
macro_rules! repro {
() => {
{
let _guard = ();
}
{
let _guard = ();
}
};
}
into this output:
macro_rules! repro {
() => {{
let _guard = ();
}
{
let _guard = ();
}};
}
I believe the original is clearer.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the macro_rules! example with rustfmt and inspect the formatting path for macro right-hand-side blocks. Done when consecutive top-level blocks retain the clearer structure shown in the issue and a regression check covers the example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100