Poor formatting of chain with 2 calls
Open
Nobody has claimed this yet.
A-call-chains
I-poor-formatting
P-low
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Running rustfmt changes the following, and I think the original formatting is better:
- let section = section
- .fde(Endian::Big, &cie1_location, &mut fde1)
- .fde(Endian::Big, &cie2_location, &mut fde2);
+ let section = section.fde(Endian::Big, &cie1_location, &mut fde1).fde(
+ Endian::Big,
+ &cie2_location,
+ &mut fde2,
+ );
If there's 3 fde calls then it is okay.
Tested with:
- 0.3.8-nightly (346238f 2018-02-04)
- 0.4.2-nightly (1415a4d 2018-04-14)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported two-call fde chain with the listed rustfmt nightly versions, then compare it with a chain containing three calls. Trace the formatter behavior responsible for the different layouts; done means the two-call chain uses the preferred multiline formatting without regressing the three-call case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100