Comment after let exceeds max width
Open
Nobody has claimed this yet.
A-comments
I-poor-formatting
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Input
fn foo() {
let file_name =
format!("{}", self.testpaths.file.display())
.replace(r"\", "/"); // on windows, translate all '\' path separators to '/'
}
Output
fn foo() {
let file_name = format!("{}", self.testpaths.file.display()).replace(r"\", "/"); // on windows, translate all '\' path separators to '/'
}
Meta
0.2.16-nightly (4e04e82 2017-11-28)
The above example is taken from https://github.com/rust-lang/rust/blob/8937d6a6cfb011d9e1fe6b4a426913dbbf9fd584/src/tools/compiletest/src/runtest.rs#L1007-L1009.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the Rust snippet from the report, then inspect rustfmt's handling of comments after a let expression. The example source is src/tools/compiletest/src/runtest.rs at lines 1007-1009; done means formatting preserves the comment without producing a line beyond the configured maximum width.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100