rust-lang / rust-lang/rustc_public

Replace String with an interned version

Open
#52 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
125
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Generating String can be very costly and inefficient. We should consider replacing most occurrences with an interned string version. We could reuse the Rust compiler Symbol structure for now or use some interner crate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by surveying the repository for String occurrences and compare the possible use of the Rust compiler Symbol structure with an interner crate. Done should mean that most relevant String uses are replaced with an agreed interned representation and the existing behavior remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.