rust-lang / rust-lang/rustc_public

Figure out why we are printing fully qualified paths for std library for tests

Open
#41 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
125
Forks
19
PR merge metrics
No merged PRs in 30d

Description

We would like to be able to enable a few test suites from rustc in our repository to provide good test coverage. Unfortunately, the ui based suites (modes ui, mir-opt, and pretty) have a lot of tests failing because of how our test driver prints fully qualified paths for standard library.

E.g.: The MIR output diff look like:

-    _10 = _eprint(move _11) -> [return: bb6, unwind unreachable];
+    _10 = std::io::_eprint(move _11) -> [return: bb6, unwind unreachable];

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failures in the ui, mir-opt, and pretty suites, then trace how the test driver prints paths in the MIR output. Compare the differing _eprint lines and determine the expected standard-library path formatting; done means these suites no longer fail because of fully qualified standard-library paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.