rust-lang / rust-lang/rustc_codegen_gcc
Make it work with rustc's debug_assert
Open
Nobody has claimed this yet.
bug
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 105
- Avg merge
- 8h 20m
- Merged PRs (30d)
- 14
Description
In rustc, there are some debug assertions that compare types.
To make them pass, we will need to at least do the following:
- Always use unsigned integers (casting to signed only when necessary).
- Always use void pointers (casting to typed pointers only when necessary).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked rustc_codegen_ssa/src/mir/rvalue.rs debug assertions and inspect the corresponding code in rustc_codegen_gcc. Trace the integer and pointer types used by those operations, then verify that rustc's assertions pass with unsigned integers and void pointers, casting only where necessary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100