rust-lang / rust-lang/rustc_codegen_gcc
Use GENERIC expressions for the rotate intrinsics
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 105
- Avg merge
- 8h 20m
- Merged PRs (30d)
- 14
Description
There's the GENERIC operation LROTATE_EXPR and RROTATE_EXPR that can be used instead of having a manual implementation of these intrinsics.
Edit: Or maybe not since they seem to want to remove this intrinsic.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the manual implementations of the rotate intrinsics in the codegen backend and checking how GENERIC operations are represented there. Verify whether LROTATE_EXPR and RROTATE_EXPR are still supported, taking the linked Rust discussion into account. Done means the issue's proposed replacement is either implemented and covered by existing tests, or its removal is confirmed as the reason not to proceed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100